v4.0.2 #136

Frix-x · 2024-06-27T16:36:00Z

Summary by Sourcery

This pull request includes enhancements to the Accelerometer class for better file write control and error handling, updates to command descriptions for clarity, and the addition of a new GitHub Actions workflow for smoke tests and linting. A new smoke test configuration file for Klippy tests has also been added.

Enhancements:
- Refactored the Accelerometer class to include reactor dependency for better control over file write operations.
- Improved error handling and timeout management for file write operations in the Accelerometer class.
- Updated command descriptions for better readability and clarity in the ShakeTune class.
CI:
- Added a new GitHub Actions workflow for smoke tests, including Klippy tests and linting.
Tests:
- Added a new smoke test configuration file for Klippy tests.

sourcery-ai · 2024-06-27T16:36:08Z

Reviewer's Guide by Sourcery

This pull request introduces several enhancements and fixes to the ShakeTune module, including the addition of new constants, refactoring of command registration, and improvements to file writing and accelerometer handling. Additionally, a new GitHub Actions workflow for smoke testing is added.

File-Level Changes

Files	Changes
`shaketune/commands/axes_map_calibration.py` `shaketune/commands/create_vibrations_profile.py` `shaketune/commands/axes_shaper_calibration.py` `shaketune/commands/compare_belts_responses.py` `shaketune/commands/excitate_axis_at_freq.py`	Modified Accelerometer instantiation to include reactor and refactored velocity limit setting for better readability.
`.github/workflows/test.yml` `ci/smoke-test/klippy-tests/simple.cfg`	Added a new GitHub Actions workflow for smoke testing and a configuration file for simple smoke tests.

Tips

Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
You can change your review settings at any time by accessing your dashboard:
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
You can always contact us if you have any questions or feedback.

sourcery-ai

Hey @Frix-x - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟡 General issues: 5 issues found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

shaketune/shaketune.py

shaketune/commands/accelerometer.py

shaketune/commands/axes_map_calibration.py

.github/workflows/test.yml

Frix-x and others added 4 commits June 20, 2024 11:59

using Klipper reactor for file write process handling

50ed13c

updated commands descriptions

37d0e39

fixed a mistake about some code that shouldn't be here...

f045b8a

feat: automated testing GitHub action (#134)

f87713e

sourcery-ai bot reviewed Jun 27, 2024

View reviewed changes

fixed pyproject.toml project name

f5a74c2

Frix-x linked an issue Jun 27, 2024 that may be closed by this pull request

project.name contains an illegal character #132

Closed

1 task

Frix-x merged commit 4a99e95 into main Jun 27, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v4.0.2 #136

v4.0.2 #136

Frix-x commented Jun 27, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jun 27, 2024 •

edited

Loading

sourcery-ai bot left a comment

v4.0.2 #136

v4.0.2 #136

Conversation

Frix-x commented Jun 27, 2024 • edited by sourcery-ai bot Loading

Summary by Sourcery

sourcery-ai bot commented Jun 27, 2024 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Frix-x commented Jun 27, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jun 27, 2024 •

edited

Loading